jms serialzier 2.0 Error in debug mode

[motia]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	yes
RFC?	no

Serialization results in an error after updating package from 1.8 to 2.0

Steps required to reproduce the problem

1. Use version 2.0
2. Enable debug mode

Expected Result

• Worked with 1.8 version

Actual Result

• An error occurs, here is the trace and the dump of ClassMetadata objects that trigger the error.

        {
            "file": "D:\\laragon\\www\\xxx\\server\\vendor\\jms\\metadata\\src\\ClassMetadata.php",
            "line": 65,
            "function": "file_exists"
        },
        {
            "file": "D:\\laragon\\www\\xxx\\server\\vendor\\jms\\metadata\\src\\MetadataFactory.php",
            "line": 96,
            "function": "isFresh",
            "class": "Metadata\\ClassMetadata",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\xxx\\server\\vendor\\jms\\serializer\\src\\GraphNavigator\\SerializationGraphNavigator.php",
            "line": 199,
            "function": "getMetadataForClass",
            "class": "Metadata\\MetadataFactory",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\xxx\\server\\vendor\\jms\\serializer\\src\\JsonSerializationVisitor.php",
            "line": 136,
            "function": "accept",
            "class": "JMS\\Serializer\\GraphNavigator\\SerializationGraphNavigator",
            "type": "->"
        },
       ...

.........JMS\Serializer\Metadata\ClassMetadata {#2499
  +preSerializeMethods: []
  +postSerializeMethods: []
  +postDeserializeMethods: []
  +xmlRootName: null
  +xmlRootNamespace: null
  +xmlRootPrefix: null
  +xmlNamespaces: []
  +accessorOrder: null
  +customOrder: null
  +usingExpression: false
  +isList: false
  +isMap: false
  +discriminatorDisabled: false
  +discriminatorBaseClass: null
  +discriminatorFieldName: null
  +discriminatorValue: null
  +discriminatorMap: []
  +discriminatorGroups: []
  +xmlDiscriminatorAttribute: false
  +xmlDiscriminatorCData: true
  +xmlDiscriminatorNamespace: null
  +name: "Closure"
  +methodMetadata: []
  +propertyMetadata: []
  +fileResources: array:1 [
    0 => false
  ]
  +createdAt: 1544094448
}

[goetas]

Thanks for reporting this issue, but actually in your report is missing the error message you are getting...

[goetas]

most probably related to #1013

[motia]

My bad I omitted the message as it was clear, in my eyes in moment.

    "message": "file_exists() expects parameter 1 to be a valid path, bool given",
    "exception": "Symfony\\Component\\Debug\\Exception\\FatalThrowableError",
    "file": "D:\\laragon\\www\\clicktruck\\server\\vendor\\jms\\metadata\\src\\ClassMetadata.php",
    "line": 65,
    "trace": [

[goetas]

I guess the underlying type was a internal class, right?

[motia]

No, I don't use any of those.
I tried to dump the classes being processed. And it seems that most of them are processed correctly besides the one causing the error.
I will try to narrow the search.

[goetas]

Do you mind trying it using jms/serializer:^2.0@dev in your composer json?

[motia]

With jms/serializer:^2.0@dev, there is no error.
Your conclusion about inner classes was spot on. I found a factory closure I was passing instead of calling in the testing environment.

Thank you @goetas .

[goetas]

👍

[goetas]

fixed by #1013