Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wildcard and basename certificates fails to create route53 record #46

Open
jesusch opened this issue Apr 12, 2021 · 2 comments
Open

wildcard and basename certificates fails to create route53 record #46

jesusch opened this issue Apr 12, 2021 · 2 comments

Comments

@jesusch
Copy link

jesusch commented Apr 12, 2021

given the following config:

custom:
  customCertificate:
    certificateName: example.com
    subjectAlternativeNames:
    - '*.example.com'

serverless-certificate-creator successfully the ACM certificate as pending
while trying to create CNAMEs it fails
the reason I found was:
the certificate returns 2 validation records to be created
but both records are identical
then serverless-certificate-creator tries to bulkcreate those 2 records, but route53 refuses it because of duplicate records.

serverless-certificate-creator could/should verify the record-list and unique() them before sending it to the route53 api?

@justinwright
Copy link

I've created a PR that should address this issue. #55

@Lynxtickler
Copy link

@schwamster Is there any chance you could have a look at this? It would be really awesome to get this feature out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants