Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express 5-alpha and npm7 #268

Closed
ex1st opened this issue Sep 23, 2021 · 3 comments
Closed

express 5-alpha and npm7 #268

ex1st opened this issue Sep 23, 2021 · 3 comments

Comments

@ex1st
Copy link

ex1st commented Sep 23, 2021

Hi,
We're using "swagger-ui-express": "4.1.6" with "express": "^5.0.0-alpha.8". It works fine for node 14 and npm 6, but after upgrade to node 16 and npm 7 we have caught the error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving:
npm ERR! Found: express@5.0.0-alpha.8
npm ERR! node_modules/express
npm ERR!   express@"^5.0.0-alpha.8" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer express@">=4.0.0" from swagger-ui-express@4.1.6
npm ERR! node_modules/swagger-ui-express
npm ERR!   swagger-ui-express@"^4.1.6" from the root project

Can you add express 5 to peerDependencies also?
Thank you!

@alanpurple
Copy link

+1

@scottie1984
Copy link
Owner

Prerelease versions are not included in the semver calculation. Until express 5 is released this error will continue.

If you want to go ahead with the install you can npm install --force

@ex1st
Copy link
Author

ex1st commented Dec 2, 2021

Hi @scottie1984 maybe you can remove express from peerDependencies in the next major release? Users can add express to package.json by themselves. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants