Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log callback is not panic-safe #2

Open
scottlamb opened this issue Mar 12, 2024 · 1 comment
Open

log callback is not panic-safe #2

scottlamb opened this issue Mar 12, 2024 · 1 comment

Comments

@scottlamb
Copy link
Owner

The log callback currently makes no attempt to prevent unwinding across the extern "C" FFI boundary, which is Undefined Behavior. It should be using std::panic::catch_unwind to prevent this. See also rust-lang/rust#86027 and rust-lang/rust#115285.
@RalfJung
Copy link

If this is about Rust-defined extern "C" functions triggering panics: once rust-lang/rust#115285 lands this issue will be resolved, as Rust will ensure that panics don't escape such functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RalfJung @scottlamb