From 4b3d66d2efd31125a532165dd5d501cb3c0b9a41 Mon Sep 17 00:00:00 2001 From: sam boyer Date: Thu, 19 Jan 2017 09:39:28 -0500 Subject: [PATCH] Update LocalImportsError to suit --- analysis.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/analysis.go b/analysis.go index f22cd8e..333ed7f 100644 --- a/analysis.go +++ b/analysis.go @@ -296,7 +296,15 @@ type LocalImportsError struct { } func (e *LocalImportsError) Error() string { - return fmt.Sprintf("import path %s had problematic local imports", e.Dir) + switch len(e.LocalImports) { + case 0: + // shouldn't be possible, but just cover the case + return fmt.Sprintf("import path %s had bad local imports", e.ImportPath) + case 1: + return fmt.Sprintf("import path %s had a local import: %q", e.ImportPath, e.LocalImports[0]) + default: + return fmt.Sprintf("import path %s had local imports: %q", e.ImportPath, strings.Join(e.LocalImports, "\", \"")) + } } func readFileBuildTags(fp string) ([]string, error) {