Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Internally-imported packages are not making it into the package list #152

Closed
sdboyer opened this issue Jan 24, 2017 · 0 comments
Closed
Assignees
Milestone

Comments

@sdboyer
Copy link
Owner

sdboyer commented Jan 24, 2017

Once I saw it, this was a big, obvious 🤦‍♂️ .

Because the ExternalReach() function is focused entirely on external imports, it entirely omits any internal packages that may be a part of that import chain. As a result, we end up missing packages in deps that are only imported internally.

For example, if our root project imports a, and (only) a imports a/foo, then a/foo will not show up in the packages list.

The fix for this is fairly complicated. I'll have to roll it in as part of #148.

@sdboyer sdboyer added this to the v0.14.0 milestone Jan 24, 2017
@sdboyer sdboyer self-assigned this Jan 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant