Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_button uses a hardcoded 2px border radius #2044

Closed
5 tasks done
caseyjhol opened this issue Sep 14, 2023 · 2 comments
Closed
5 tasks done

remove_button uses a hardcoded 2px border radius #2044

caseyjhol opened this issue Sep 14, 2023 · 2 comments

Comments

@caseyjhol
Copy link

caseyjhol commented Sep 14, 2023

I did:

  • Search for if my issue has already been submitted
  • Make sure I'm reporting something precise that needs to be fixed
  • Give my issue a descriptive and concise title
  • Create a minimal working example on JsFiddle or Codepen
    (or gave a link to a demo on the Selectize docs)
  • Indicate precise steps to reproduce in numbers and the result,
    like below

It's possible to override @selectize-border-radius. For the .item styling, the border radius is set to @selectize-border-radius - 1px. However, this same styling is not used for the remove button (it's instead hardcoded to 2px). As a result, when hovering over the button, the border radius does not match up.

Steps to reproduce:

  1. Override @selectize-border-radius to something other than 3px.
  2. Use the remove_button plugin.
  3. See that the border-radius does not update to take the new border radius into account (it's hardcoded to 2px).

See an example here: https://codepen.io/caseyjhol-the-animator/pen/wvRqMwx

  1. Select some items.
  2. Hover over the remove button.

Expected result:
image
image

Actual result:
image
image

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
@caseyjhol
Copy link
Author

Still an issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant