From f49b0f810200a2b03adfaf1c444f18c13db7d6ac Mon Sep 17 00:00:00 2001 From: echo Date: Fri, 6 May 2022 16:54:21 +0800 Subject: [PATCH] Small opt when prune messages (#1389) * Small opt when prune messages * Fix typing error --- bridges/modules/messages/src/outbound_lane.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bridges/modules/messages/src/outbound_lane.rs b/bridges/modules/messages/src/outbound_lane.rs index e4566b8895fa4..041dec214b11c 100644 --- a/bridges/modules/messages/src/outbound_lane.rs +++ b/bridges/modules/messages/src/outbound_lane.rs @@ -148,19 +148,17 @@ impl OutboundLane { /// Returns number of pruned messages. pub fn prune_messages(&mut self, max_messages_to_prune: MessageNonce) -> MessageNonce { let mut pruned_messages = 0; - let mut anything_changed = false; let mut data = self.storage.data(); while pruned_messages < max_messages_to_prune && data.oldest_unpruned_nonce <= data.latest_received_nonce { self.storage.remove_message(&data.oldest_unpruned_nonce); - anything_changed = true; pruned_messages += 1; data.oldest_unpruned_nonce += 1; } - if anything_changed { + if pruned_messages > 0 { self.storage.set_data(data); }