Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase flexibility in API-url replacement #16

Closed
seriema opened this issue Oct 19, 2014 · 3 comments
Closed

Increase flexibility in API-url replacement #16

seriema opened this issue Oct 19, 2014 · 3 comments
Milestone

Comments

@seriema
Copy link
Owner

seriema commented Oct 19, 2014

Currently apiMock simply does a string.replace to change apiPath into mockDataPath.

Two other options could be added:

  1. Use a regex for apiPath.
  2. Use a method for mockDataPath.
@seriema seriema added this to the 0.2.0 milestone Oct 19, 2014
@seriema
Copy link
Owner Author

seriema commented Aug 30, 2015

Does anyone really want this or was I just feature-creeping?

@Wolfium
Copy link
Contributor

Wolfium commented Sep 12, 2015

+1, excellent work, I thought on being backward compatibility being able to handle an array of strings and/or regexs leaving simple string to not get a breaking change.

By the way the only issue I have is only work with true option, don't work if I use auto or number for status code.
Even not working in demo http://johansson.jp/angular-apimock/#/demo-simple?apimock=auto

@seriema
Copy link
Owner Author

seriema commented Sep 13, 2015

@Wolfium I created an issue for the bug you reported: #37 Feel free to add any details if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants