Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record SourceContext in InstrumentationScope.Name #112

Closed
nblumhardt opened this issue Oct 16, 2023 · 0 comments · Fixed by #113
Closed

Record SourceContext in InstrumentationScope.Name #112

nblumhardt opened this issue Oct 16, 2023 · 0 comments · Fixed by #113
Labels
enhancement New feature or request

Comments

@nblumhardt
Copy link
Member

See: open-telemetry/opentelemetry-dotnet#4941

This should probably remove SourceContext from the regular set of attributes.

I'm uncertain whether all receivers will provide a pleasant consumption experience for instrumentation scope names, we might consider gating the new behavior on a (default-enabled) IncludedData.InstrumentationScopeName or similar, in the 1.x series of releases, so that the setting can be disabled and the old behavior restored if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant