Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Faulty cast to boolean #2

Closed
estebanthebad opened this issue Apr 28, 2022 · 2 comments
Closed

[BUG] Faulty cast to boolean #2

estebanthebad opened this issue Apr 28, 2022 · 2 comments

Comments

@estebanthebad
Copy link

estebanthebad commented Apr 28, 2022 •
edited
Loading

Hey again!

https://github.com/sms77io/php-client/blob/ec0339d72bcdfa930b80ab1c8cd2e2838b944d46/src/Response/Sms.php#L19

(bool)"false" does not evaluate to the boolean value FALSE but to the boolean value TRUE.

https://www.php.net/manual/en/language.types.boolean.php

;)
Cheers!
@matthiez
Copy link
Member

matthiez commented May 6, 2022

thanks for reporting @estebanthebad will fix asap in the next release but im quite busy with other stuff atm - feel free to open a pull request on your own though :)

@cl77
Copy link
Member

cl77 commented Apr 26, 2024

Fixed with latest release.

@cl77 cl77 closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthiez @cl77 @estebanthebad