Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExoPlayer requires text track duration not to be shorter than video/audio duration #356

Open
kqyang opened this issue Mar 23, 2018 · 5 comments
Labels
type: enhancement New feature or request type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Milestone

Comments

@kqyang
Copy link
Contributor

kqyang commented Mar 23, 2018

See google/ExoPlayer#3317 and google/ExoPlayer#4029, ExoPlayer (v2.6.1) calculates media duration from the shortest Representation. So if text tracks end early, ExoPlayer won't play all the way to the end of the media.

We need to pad subtitle tracks with empty chunks, extending them to match with video duration. That is not required by DASH spec, but it is the only way to make it work on ExoPlayer.

@kqyang kqyang added this to the v2.1 milestone Mar 23, 2018
@kqyang kqyang added type: external An issue with an external dependency; not our issue; sometimes kept open for tracking type: enhancement New feature or request labels Mar 23, 2018
@ojw28
Copy link

ojw28 commented Apr 3, 2018

As per the ExoPlayer issue, we will endeavor to support this case primarily due to the time that will be required to update packagers such as shaka to pad representations with empty segments, and also due to existing content that's already been packaged.

However, since the DASH-IF discussion appears to be headed in the direction of recommending padding segments, I'd expect this issue to remain open and be addressed in shaka packager at some point (unless the DASH-IF discussion changes course and short representations end up being explicitly allowed).

@kqyang
Copy link
Contributor Author

kqyang commented Apr 3, 2018

@ojw28 Thanks! Move this issue to backlog for now. We will review again once DASH-IF discussion is finalized.

@kqyang kqyang modified the milestones: v2.1, Backlog Apr 3, 2018
@vaage vaage removed their assignment Apr 5, 2018
@okycelt
Copy link

okycelt commented Sep 25, 2018

Hello, do you have any update on this?

@kqyang
Copy link
Contributor Author

kqyang commented Sep 25, 2018

@okycelt This is low priority for us right now as it is no longer a problem in ExoPlayer. Let us know if you think we should bump the priority.

@okycelt
Copy link

okycelt commented Sep 25, 2018

@kqyang Sorry, we've missed that ExoPlayer is supporting this already. We're using 2.8.2, will try with the latest version. Thank you for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Projects
None yet
Development

No branches or pull requests

4 participants