[Bug]: Keep not played for X days setting not respsected

[xiNeRoar]

What happened?

I have tried to configure keep not played for X days from 1 to 30, the plugin will keep everything since someone has watched it no matter how long it was

Troubleshooting info

This is the only occurrence of the show watch which is 2 months ago;

This is my setting;

This is the original log;
log.txt

[shemanaev]

Hi, will setting like "don't count item as played after X days of last play" solve this problem?

For example: the value is set to 10, the last time the TV show episode was watched on January 10th, so after January 20th this play will not be counted.

[xiNeRoar]

Hi, will setting like "don't count item as played after X days of last play" solve this problem?

For example: the value is set to 10, the last time the TV show episode was watched on January 10th, so after January 20th this play will not be counted.

yes I think so, but I think how this setting interact with "keep not played episode for x days" need to be treated or documented carefully?
Also, as the original purpose of this plugin is to "delete played media files after specified amount of time", I guess re-group the options into two main category will help user better understand how they should setup the plugin?

e.g.;

1. Delete media after played
   Time - [ ] Days
   Trigger Scope - [ ] Single Episode / Whole Season / Whole Series
   Delete Scope - [ ] Single Episode / Whole Season / Whole Series
   Monitor - [ ] All User / Any User / Any User(Latest Playback)

2. Delete media after not being played
   Time - [ ] Days
   Trigger Scope - [ ] Single Episode / Whole Season / Whole Series
   Delete Scope - [ ] Single Episode / Whole Season / Whole Series
   Monitor - [ ] All User / Any User / Any User(Latest Playback)

[shemanaev]

yes I think so, but I think how this setting interact with "keep not played episode for x days" need to be treated or documented carefully?

Could you try this build?

Also, as the original purpose of this plugin is to "delete played media files after specified amount of time", I guess re-group the options into two main category will help user better understand how they should setup the plugin?

e.g.;

1. Delete media after played
   Time - [ ] Days
   Trigger Scope - [ ] Single Episode / Whole Season / Whole Series
   Delete Scope - [ ] Single Episode / Whole Season / Whole Series
   Monitor - [ ] All User / Any User / Any User(Latest Playback)

2. Delete media after not being played
   Time - [ ] Days
   Trigger Scope - [ ] Single Episode / Whole Season / Whole Series
   Delete Scope - [ ] Single Episode / Whole Season / Whole Series
   Monitor - [ ] All User / Any User / Any User(Latest Playback)

That's a good suggestion, I will look into it. Current UX isn't great for sure, it started as simple plugin for my needs and grows with features.

[xiNeRoar]

yes I think so, but I think how this setting interact with "keep not played episode for x days" need to be treated or documented carefully?

Could you try this build?

Also, as the original purpose of this plugin is to "delete played media files after specified amount of time", I guess re-group the options into two main category will help user better understand how they should setup the plugin?
e.g.;

1. Delete media after played
   Time - [ ] Days
   Trigger Scope - [ ] Single Episode / Whole Season / Whole Series
   Delete Scope - [ ] Single Episode / Whole Season / Whole Series
   Monitor - [ ] All User / Any User / Any User(Latest Playback)

2. Delete media after not being played
   Time - [ ] Days
   Trigger Scope - [ ] Single Episode / Whole Season / Whole Series
   Delete Scope - [ ] Single Episode / Whole Season / Whole Series
   Monitor - [ ] All User / Any User / Any User(Latest Playback)

That's a good suggestion, I will look into it. Current UX isn't great for sure, it started as simple plugin for my needs and grows with features.

I am more than willing to try it out but I am not so familiar with the file, how can I use it?

[shemanaev]

I am more than willing to try it out but I am not so familiar with the file, how can I use it?

Just unzip it, replace original dll (<Jellyfin config folder>/plugins/Media Cleaner_2.17.0.0) and restart server.

[xiNeRoar]

I tried and here is the log;
log.txt
the item being tested is "鬼灭之刃" season 1 and 4, they only played once on 07/23/2023 but still endup the cleanup task doesn't list out this season to delete

[shemanaev]

I tried and here is the log; log.txt the item being tested is "鬼灭之刃" season 1 and 4, they only played once on 07/23/2023 but still endup the cleanup task doesn't list out this season to delete

You need to configure the new option first

[xiNeRoar]

thanks it seems working! :) but i still need to observe it for couple days to ensure it works as intended


I was trying to configure it to only acknowledge current day's watch state. If someone watch it today, extend it for another 30 days. If no one watch it, it will count down 30 days until being deleted. I will try to shorten the period from 30 days to 2 or 3 days and observe how it operate and report here :D

[shemanaev]

Value "30" should do it. Like "if no one watched in last 30 days".

observe how it operate and report here :D

I will keep an eye on it 😉

[NicolaSmaniotto]

Hi, just want to say that I'm testing this new build and everything seems to work as expected.

Also, it fixes the thing I mentioned in #39 (comment), because if someone drops a series its partial plays are now ignored after X days, and it is then removed because nobody watched it.

With these changes the plugin does pretty much everything I wanted it to, thanks!