Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

oot2k - FootiumPrizeDistributor should use SafeERC20 functions #38

Closed
sherlock-admin opened this issue May 5, 2023 · 0 comments
Closed
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 5, 2023

oot2k

medium

FootiumPrizeDistributor should use SafeERC20 functions

Summary

The claimERC20Prize() function of FootiumPrizeDistributor uses token.transfer to transfer tokens. This function can silently revert (USDT...) and not transfer any token, while still updating the totalERC20Claimed.
The user will now lose funds.

Vulnerability Detail

The claimERC20Prize() function of FootiumPrizeDistributor uses token.transfer can lead to wrong stored totalERC20Claimed.

Impact

Possible loss of funds for Prize Receiver.

Code Snippet

https://github.com/sherlock-audit/2023-04-footium/blob/main/footium-eth-shareable/contracts/FootiumPrizeDistributor.sol#L130

Tool used

Manual Review

Recommendation

We recommend using openzeppelin SafeTransfer functions.

Duplicate of #86

@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels May 10, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant