You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.
sherlock-admin opened this issue
May 5, 2023
· 0 comments
Labels
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelMediumA valid Medium severity issueRewardA payout will be made for this issue
FootiumPrizeDistributor should use SafeERC20 functions
Summary
The claimERC20Prize() function of FootiumPrizeDistributor uses token.transfer to transfer tokens. This function can silently revert (USDT...) and not transfer any token, while still updating the totalERC20Claimed.
The user will now lose funds.
Vulnerability Detail
The claimERC20Prize() function of FootiumPrizeDistributor uses token.transfer can lead to wrong stored totalERC20Claimed.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelMediumA valid Medium severity issueRewardA payout will be made for this issue
oot2k
medium
FootiumPrizeDistributor should use SafeERC20 functions
Summary
The claimERC20Prize() function of FootiumPrizeDistributor uses token.transfer to transfer tokens. This function can silently revert (USDT...) and not transfer any token, while still updating the totalERC20Claimed.
The user will now lose funds.
Vulnerability Detail
The claimERC20Prize() function of FootiumPrizeDistributor uses token.transfer can lead to wrong stored totalERC20Claimed.
Impact
Possible loss of funds for Prize Receiver.
Code Snippet
https://github.com/sherlock-audit/2023-04-footium/blob/main/footium-eth-shareable/contracts/FootiumPrizeDistributor.sol#L130
Tool used
Manual Review
Recommendation
We recommend using openzeppelin SafeTransfer functions.
Duplicate of #86
The text was updated successfully, but these errors were encountered: