Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow in dialogue box #1083

Open
moritztim opened this issue Jun 10, 2024 · 0 comments
Open

Overflow in dialogue box #1083

moritztim opened this issue Jun 10, 2024 · 0 comments

Comments

@moritztim
Copy link

The problem

the dialogue box for switching from a branch with uncommitted changes incorrectly handles overflow
The text "You have changes on this branch. What would you like to do with them" overruns the message box.

Release version

3.3.18-linux1 (x64)

Operating system

Arch linux

Steps to reproduce the behavior

  1. Open a repository
  2. Create a branch
  3. Make changes
  4. Switch to another branch

Log files

n/a

Screenshots

Dialogue box

Additional context

<dialog id="stash-changes" class="tooltip-host modal-enter-done" aria-labelledby="__Dialog_stash-changes_Switch_branch" tabindex="-1" open=""><div class="dialog-header"><h1 id="__Dialog_stash-changes_Switch_branch">Switch branch</h1><button class="close" aria-label="Close"><svg aria-hidden="true" class="octicon" version="1.1" viewBox="0 0 16 16" tabindex="-1" height="16" width="16"><path d="M3.72 3.72a.75.75 0 0 1 1.06 0L8 6.94l3.22-3.22a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l3.22 3.22a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-3.22 3.22a.751.751 0 0 1-1.042-.018.751.751 0 0 1-.018-1.042L6.94 8 3.72 4.78a.75.75 0 0 1 0-1.06Z"></path></svg></button></div><form><fieldset><div class="dialog-content"><div class="row-component"><fieldset class="vertical-segmented-control"><legend>You have changes on this branch. What would you like to do with them?</legend><ul id="__VerticalSegmentedControl_You_have_changes_on_this_branch._What_would_you_like_to_do_with_them_" class="vertical-segmented-control" tabindex="0" role="radiogroup" aria-activedescendant="__VerticalSegmentedControl_You_have_changes_on_this_branch._What_would_you_like_to_do_with_them__Item_0"><li class="selected" role="radio" id="__VerticalSegmentedControl_You_have_changes_on_this_branch._What_would_you_like_to_do_with_them__Item_0" aria-checked="true"><div class="title">Leave my changes on foo</div><p>Your in-progress work will be stashed on this branch for you to return to later</p></li><li role="radio" id="__VerticalSegmentedControl_You_have_changes_on_this_branch._What_would_you_like_to_do_with_them__Item_1" aria-checked="false"><div class="title">Bring my changes to main</div><p>Your in-progress work will follow you to the new branch</p></li></ul></fieldset></div></div><div class="dialog-footer"><div class="button-group"><button class="button-component" type="submit">Switch branch</button><button class="button-component" type="reset">Cancel</button></div></div></fieldset></form></dialog>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants