Icon does not scale well on Ubuntu

[kevinhikaruevans]

Describe the feature or problem you’d like to solve

The icon does not downscale well on Ubuntu 20.04. I'm using Github Desktop 2.5.4-linux1. Here's a screenshot of my activity bar next to other applications:

This is a fairly minor problem but it just looks odd next to the other icons.

Proposed solution

The ideal solution would be to include 128x128, 64x64, 32x32 prescaled icons and an svg. I think the issue is downscaling is done using nearest neighbor on a large icon, and it'd be better to just include the smaller icons instead and a vector image.

Here's what it should look like in comparison:

[shiftkey]

@kevinhikaruevans thanks for the report. I'm a bit puzzled about this one but here's some context about the packaging side of things.

These are the versions I'm specifying to electron-installer-debian:

desktop/script/package-debian.ts

Lines 59 to 63 in 3945af9

	icon: {
	'256x256': 'app/static/logos/256x256.png',
	'512x512': 'app/static/logos/512x512.png',
	'1024x1024': 'app/static/logos/1024x1024.png',
	},

This seems to work fine based on the docs: https://github.com/electron-userland/electron-installer-debian#optionsicon

I'm not sure if there's an SVG version of the icon around that could be used here, but it would be worth checking the installer is actually using these values, and not falling back to something else unexpected here.

[kevinhikaruevans]

I've added a PR that adds in the smaller icons. I tested it and it looks less jagged. 👍

There is an svg available here: https://desktop.github.com/images/desktop-icon.svg but it looks a little different from the pngs, so I didn't include it.