-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oxipng corrupts certain images #29
Labels
I-Critical
Issues that are breaking core functionality for a significant portion of users
T-Bug
Some piece of the software is not working as intended
T-Needs Tests
Comments
As @ion1 suggested, I attempted to flip the image so the subtitles are on top, and as it turns out this affects whether the images are corrupted or not.
Note that no corruption occurs. EDIT: Cropping from top or bottom also changes the outcome. |
shssoichiro
added
T-Bug
Some piece of the software is not working as intended
I-Critical
Issues that are breaking core functionality for a significant portion of users
T-Needs Tests
labels
Mar 10, 2016
The images which resulted in corruption before no longer appear to get corrupted. |
Great. I'll add a test to make sure the behavior doesn't return, then I'll count this as closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I-Critical
Issues that are breaking core functionality for a significant portion of users
T-Bug
Some piece of the software is not working as intended
T-Needs Tests
I used the following script to run oxipng on a large number of PNG files from my mpv screenshot directory (~650 files), comparing the output of oxipng with the original file using graphicsmagick's compare command. The oxipng version used was 3f42eae.
A number of images where the output did not correspond to the input were detected.
(For reasons beyond my comprehension, KonoSuba screenshots seemed to be more likely to get corrupted than others; I'm going to assume oxipng has bad taste in anime.)
As one can see, subtitles, for some reason, often trigger this.
rustc version is
rustc 1.9.0-nightly (998a6720b 2016-03-07)
.The text was updated successfully, but these errors were encountered: