Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BeaconChain::kzg mandatory #6260

Open
michaelsproul opened this issue Aug 15, 2024 · 0 comments
Open

Make BeaconChain::kzg mandatory #6260

michaelsproul opened this issue Aug 15, 2024 · 0 comments
Labels
code-quality v6.0.0 New major release for hierarchical state diffs

Comments

@michaelsproul
Copy link
Member

Description

The kzg field of the BeaconChain is unnecessarily wrapped in an Option.

lighthouse/beacon_node/beacon_chain/src/beacon_chain.rs

Lines 493 to 494 in d6ba8c3

/// The KZG trusted setup used by this chain.
pub kzg: Option<Arc<Kzg>>,

Removing this would simplify some error handling because we don't need to handle the case where the kzg setup is not initialized.

Version

Lighthouse v5.3.0
@michaelsproul michaelsproul added code-quality v5.3.0 Q3 2024 release with database changes! v6.0.0 New major release for hierarchical state diffs and removed v5.3.0 Q3 2024 release with database changes! labels Aug 15, 2024
@eserilev eserilev mentioned this issue Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality v6.0.0 New major release for hierarchical state diffs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul