New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic RNG in peer DAS publish block tests #6296

Open

michaelsproul opened this issue Aug 22, 2024 · 0 comments

Labels

code-quality das test improvement

Member

michaelsproul commented Aug 22, 2024 •

edited by dapplion

Loading

Description

It would be good to make the tests deterministic by using a seeded RNG here:

#5683 (comment)

lighthouse/beacon_node/http_api/src/publish_blocks.rs

Line 128 in ea331a9

data_col_sidecars.shuffle(&mut rand::thread_rng());

michaelsproul added test improvement code-quality das labels

michaelsproul mentioned this issue

PeerDAS implementation #5683

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment