Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if any of the data columns are slashable before publishing #6372

Open
jimmygchen opened this issue Sep 9, 2024 · 2 comments
Open

Check if any of the data columns are slashable before publishing #6372

jimmygchen opened this issue Sep 9, 2024 · 2 comments
Labels
das Data Availability Sampling

Comments

@jimmygchen
Copy link
Member

Description

When publishing a block, we check if any of the block and blobs are slashable here:

/// Check if any of the blobs or the block are slashable. Returns `BlockError::Slashable` if so.
fn check_slashable<T: BeaconChainTypes>(
chain_clone: &BeaconChain<T>,
blobs_opt: &Option<BlobSidecarList<T::EthSpec>>,
block_root: Hash256,
block_clone: &SignedBeaconBlock<T::EthSpec, FullPayload<T::EthSpec>>,
log_clone: &Logger,
) -> Result<(), BlockError> {

We need to add the equivalent check for data column sidecars here too.

@jimmygchen jimmygchen added the das Data Availability Sampling label Sep 9, 2024
@michaelsproul
Copy link
Member

I was kind of looking at this in the context of:

Didn't impl it yet though

@jimmygchen
Copy link
Member Author

I'm actually wondering if it's necessary to pass blobs / data columns to this function, because the block headers are derived from the block, so it seems redundant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling
Projects
None yet
Development

No branches or pull requests

2 participants