-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(*models.Error) is not supported by the TextConsumer #1115
Comments
I'm suspect that you're getting a 429 response due to rate limiting, but since that is formatted by nginx as HTML (instead of JSON which is what the rekor client expects by default). be91b71 (which is in 1.0rc) changes the underlying HTTP client to quietly attempt retries according to the Retry-After headers returned by the gateway). That probably won't definitively fix the error you're reporting here, but should make it happen drastically less often. |
@ianlewis has upgrading to rekor v1.0.0 helped in this? |
@bobcallaway I think we're still evaluating. I don't think we have a release with it included but I'll see how often it occurs in our e2e tests this week. |
@bobcallaway We actually didn't update Rekor to 1.0.0 in in slsa-github-generator yet. We only had updated it in the verifier. Hopefully slsa-framework/slsa-github-generator#1121 will get merged in the next day or so and we'll see results. |
We've upgraded to rekor 1.0 and haven't seen this error since upgrading. Closing. |
We're seeing this error in a non-trivial number of our e2e test runs w/ slsa-github-generator.
As with #801 it seems to be a transient error. A quick Google search returned go-swagger/go-swagger#1929 which seems to be unresolved in the swagger library but there are some clues there as to potential ways to work around it.
The text was updated successfully, but these errors were encountered: