Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define GitHub variables #1261

Closed
Tracked by #1247
jku opened this issue Jun 6, 2024 · 5 comments
Closed
Tracked by #1247

Define GitHub variables #1261

jku opened this issue Jun 6, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented Jun 6, 2024

As part of #1247 I'd like to define a GH secret.

  • Secret TUF_ON_CI_TOKEN: this should be a sigstore-bot token with following permissions for sigstore/root-signing:
    • Actions: write to dispatch other workflows when needed
    • Contents: write to create online signing commits, and to create targets metadata change commits in signing events
    • Issues: write to create issues for workflow failures
    • Pull requests: write to create and modify signing event pull requests

There may already be a token but I'd like a new one to get the right name and to double check the permissions (they may not match exactly what the legacy systems needs).


Originally I was planning to also set two variables but that would only make sense if sigstore/github-sync would support them -- I will instead include them in the workflow in #1256

@jku jku added the enhancement New feature or request label Jun 6, 2024
@jku

This comment was marked as outdated.

@jku
Copy link
Member Author

jku commented Aug 20, 2024

for reference there is also an issue for using a GitHub App instead of a plain token sigstore/root-signing-staging#98 -- I plan to test that in staging but that's not done yet

@haydentherapper
Copy link
Contributor

@bobcallaway Do you have access to sigstore-bot and can do this? (Also, how do we get access to sigstore-bot?)

@bobcallaway
Copy link
Member

@bobcallaway Do you have access to sigstore-bot and can do this? (Also, how do we get access to sigstore-bot?)

yes

@jku
Copy link
Member Author

jku commented Aug 21, 2024

Thanks, this should now be sorted. We will see when the smoke clears after #1323

@jku jku closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants