From f0e58b7598d9d5afa5f6898ba030a258a2cb84d7 Mon Sep 17 00:00:00 2001 From: Kevin de Berk Date: Fri, 17 Nov 2023 00:11:29 +0100 Subject: [PATCH] feat: accept empty metrics (#30) Co-authored-by: Kevin de Berk --- src/aggregator.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/aggregator.rs b/src/aggregator.rs index 302c5dc..5d8c593 100644 --- a/src/aggregator.rs +++ b/src/aggregator.rs @@ -300,12 +300,20 @@ impl AggregationFamily { ))); } + // Sometimes, either the family we set previously, or the family we're now merging with now only contain + // a #TYPE and #HELP line, but no actual metric values. + let new_is_empty = !new_family.iter_samples().any(|_| { true }); + let old_is_empty = !self.base_family.iter_samples().any(|_| { true }); + // We should clear the whole family if any of the samples has a clearmode="family" label let should_clear_family = new_family.iter_samples().any(|metric| { ClearMode::from_family(new_family.family_type.clone(), metric) == ClearMode::Family }); - if should_clear_family { + if new_is_empty { + return Ok(()) + } + else if old_is_empty || should_clear_family { self.base_family = new_family.without_label(CLEARMODE_LABEL_NAME).unwrap_or(new_family); } else {