From 3159281f2fb027b2427940be9465624455d428f2 Mon Sep 17 00:00:00 2001
From: Romil Bhardwaj <romil.bhardwaj@berkeley.edu>
Date: Fri, 6 Sep 2024 16:06:49 -0700
Subject: [PATCH] [k8s] Fix generate_kubeconfig.sh when ingress is not used
 (#3864)

* fix kubeconfig generate script

* updates
---
 sky/utils/kubernetes/generate_kubeconfig.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sky/utils/kubernetes/generate_kubeconfig.sh b/sky/utils/kubernetes/generate_kubeconfig.sh
index 04ea567d3f2..8923df9c051 100755
--- a/sky/utils/kubernetes/generate_kubeconfig.sh
+++ b/sky/utils/kubernetes/generate_kubeconfig.sh
@@ -169,7 +169,9 @@ roleRef:
   kind: Role
   name: skypilot-system-service-account-role
   apiGroup: rbac.authorization.k8s.io
----
+EOF
+# Apply optional ingress-related roles, but don't make the script fail if it fails
+kubectl apply -f - <<EOF || echo "Failed to apply optional ingress-related roles. Nginx ingress is likely not installed. This is not critical and the script will continue."
 # Optional: Role for accessing ingress resources
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role