Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Fix check for NSG creation while opening port #3843

Open
landscapepainter opened this issue Aug 18, 2024 · 0 comments · May be fixed by #3844
Open

[Azure] Fix check for NSG creation while opening port #3843

landscapepainter opened this issue Aug 18, 2024 · 0 comments · May be fixed by #3844

Comments

@landscapepainter
Copy link
Collaborator

Regards to nsg.provisioning_state not in ['Creating', 'Updating'] at provision/azure/instance.py::open_ports, it seems like we are waiting until the provisioning_state is updated to move on from either 'Creating' or 'Updating'. But nsg.provisioning_state would not be updated as the .provisioning_state does not stay synced with Azure's backend unless we refresh by calling list_network_security_groups(resource_group) again. Hence, current bug stays in an infinite loop when nsg.provisioning_state was either 'Creating' or 'Updating' when first list_network_security_groups(resource_group)was called within the for-loop.

We must add a logic to refresh by calling list_network_security_groups(resource_group) each time the check fails.

Screenshot 2024-08-18 at 4 52 43 PM

Version & Commit info:

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
@landscapepainter landscapepainter linked a pull request Aug 18, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant