Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toggle Group] Make available in all themes #1163

Open
1 task
Tracked by #958
DanielleRameau opened this issue Apr 9, 2024 · 0 comments · May be fixed by #1524
Open
1 task
Tracked by #958

[Toggle Group] Make available in all themes #1163

DanielleRameau opened this issue Apr 9, 2024 · 0 comments · May be fixed by #1524
Assignees
Labels
tokens Setting up base tokens

Comments

@DanielleRameau
Copy link
Collaborator

DanielleRameau commented Apr 9, 2024

Toggle button review

Sanoma Learning dark

  • disabled button and idle button look the same, idle should be fully white

ItsLearning, kampus, max online and TEAS

  • inconsistency between ghost and outline icon colors in the disabled state, it should be the same

Tooltip review

All themes

  • I prefer to have a bit more padding on the left and right side of the tooltip
  • border color of separator has to be darker then in selected background color

Clickedu, magister light

  • tooltip background color should be darker

Itslearning

  • font in tooltip looks bold, it should be regular

Toggle group review

Bingel DC, my digital book, clickedu, neon
Is there a possibility to add more spacing in the start button (left) and end button (right) when the theme has fully rounded corners?

Editorials suite

  • in the medium toggle group the text is bold and in the large variant regular (discuss with the designer of editorial suite, they did this request when we created this theme for them but I’m not sure if we should have this inconsistency)

neon light, neon dark, teas

  • background color of the selected state is too light in my opinion, discuss with designer of cfa

Tasks

  1. UI bug
@DanielleRameau DanielleRameau added the tokens Setting up base tokens label Apr 9, 2024
@DanielleRameau DanielleRameau self-assigned this Apr 9, 2024
@DanielleRameau DanielleRameau changed the title [Button Group] Make available in all themes [Toggle Group] Make available in all themes Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tokens Setting up base tokens
Projects
Status: 👀 Needs review
Development

Successfully merging a pull request may close this issue.

1 participant