Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show example of customing the attestation output #353

Closed
chipzoller opened this issue Jun 19, 2022 · 5 comments · Fixed by #618
Closed

Show example of customing the attestation output #353

chipzoller opened this issue Jun 19, 2022 · 5 comments · Fixed by #618
Assignees
Labels
type:documentation Improvements or additions to documentation type:feature New feature or request

Comments

@chipzoller
Copy link
Contributor

chipzoller commented Jun 19, 2022

It'd be nice in the README here if you could show an example of how to use the workflow output attestation-name to customize the name of the uploaded attestation. The input is shown (because it's required), but the output isn't and the default output file appears to be attestation.intoto.jsonl.

@ianlewis
Copy link
Member

Just to clarify, where would you like to customize it? on the workflow run or on the release?

There is an example where it's used in the release step of the second example but I'd like to understand the use case you're thinking of.

@ianlewis ianlewis added type:documentation Improvements or additions to documentation type:feature New feature or request labels Jun 20, 2022
@chipzoller
Copy link
Contributor Author

chipzoller commented Jun 20, 2022

In the workflow itself. In my case, I already had an existing workflow which assumed the name of the Go generator and I wanted to retain the same name. I wasn't sure how to configure that output value because the README didn't show this, so I ended up guessing wrong a couple times and just updated my workflow to use the default name instead.

@ianlewis
Copy link
Member

Right now there isn't an input that would allow you to change the name. I suppose we could add one but I think we want to keep inputs to a minimum if we can. The workflow itself is temporary so feels a bit arbitrary to me, but I can definitely see the need for customization on the release. Do you have an example somewhere we could look at?

@ianlewis
Copy link
Member

We added an input to customize the attestation file name a while back and I created a PR to document it in #618. I think that should allow us to close this issue.

wdut? @chipzoller

@ianlewis ianlewis self-assigned this Jul 22, 2022
@chipzoller
Copy link
Contributor Author

Yes, that looks good, and thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements or additions to documentation type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants