Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Loader.toCollectorPayload should emit only one bad row and not a list #56

Open
chuwy opened this issue Jun 19, 2020 · 2 comments
Open

Common: Loader.toCollectorPayload should emit only one bad row and not a list #56

chuwy opened this issue Jun 19, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@chuwy
Copy link
Contributor

chuwy commented Jun 19, 2020 

Loader[T] {
  def toCollectorPayload(
    line: T,
    processor: Processor
  ): ValidatedNel[BadRow.CPFormatViolation, Option[CollectorPayload]]

The function signature indicates that several CPFormatViolation bad rows can be emitted for one CollectorPayload, whereas it should be maximum one.
@chuwy
Copy link
Contributor Author

chuwy commented Jun 19, 2020

Migrated from snowplow/snowplow#4315 (comments are auto-generated)

@chuwy chuwy mentioned this issue Jun 19, 2020
Closed
@chuwy chuwy added the bug Something isn't working label Jun 19, 2020
@benjben benjben mentioned this issue Sep 16, 2020
Merged
12 tasks
@chuwy
Copy link
Contributor Author

chuwy commented Oct 9, 2020

Following this conversation: #328 (comment), @benjben. I checked this function and in fact it's not that easy to get rid of NonEmptyList right now - we're blocked by snowplow/snowplow-badrows#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chuwy