fix: Allow package.json to have missing dependency property

snyk · Oct 5, 2018 · 55de7e0 · 55de7e0
1 parent 4254065
commit 55de7e0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/lib/index.ts b/lib/index.ts
@@ -47,9 +47,7 @@ async function buildDepTree(
   }
 
   const manifestFile: ManifestFile = parseManifestFile(manifestFileContents);
-  if (!manifestFile.dependencies && !includeDev) {
-    throw new Error("No 'dependencies' property in package.json");
-  }
+
   const lockFile: Lockfile = lockfileParser.parseLockFile(lockFileContents);
   return lockfileParser.getDependencyTree(manifestFile, lockFile, includeDev);
 }

diff --git a/test/lib/fixtures/dev-deps-only/expected-tree-empty.json b/test/lib/fixtures/dev-deps-only/expected-tree-empty.json
@@ -0,0 +1,6 @@
+{
+  "name": "pkg-dev-deps-only",
+  "version": "0.0.1",
+  "hasDevDependencies": true,
+  "dependencies": {}
+}
diff --git a/test/lib/package-lock.ts b/test/lib/package-lock.ts
@@ -115,6 +115,17 @@ test('Parse npm package-lock.json with dev deps only', async (t) => {
   t.deepEqual(depTree, expectedDepTree, 'Tree is created with dev deps only');
 });
 
+test('Parse npm package-lock.json with dev deps only', async (t) => {
+  const expectedDepTreeEmpty = load('dev-deps-only/expected-tree-empty.json');
+  const depTree = await buildDepTreeFromFiles(
+    `${__dirname}/fixtures/dev-deps-only/`,
+    'package.json',
+    'package-lock.json',
+    false,
+  );
+  t.deepEqual(depTree, expectedDepTreeEmpty, 'Tree is created empty');
+});
+
 test('Parse npm package-lock.json with cyclic deps', async (t) => {
   const depTree = await buildDepTreeFromFiles(
     `${__dirname}/fixtures/cyclic-dep-simple/`,