Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: solid-start-file-system-router not generating sourcemaps #1088

Closed
2 tasks done
elijah629 opened this issue Oct 21, 2023 · 1 comment
Closed
2 tasks done

[Bug?]: solid-start-file-system-router not generating sourcemaps #1088

elijah629 opened this issue Oct 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@elijah629
Copy link

elijah629 commented Oct 21, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

solid-start-file-system-router does not generate sourcemaps. This is seen as vite shows an error during build:

(solid-start-file-system-router plugin) Sourcemap is likely to be incorrect: a plugin (solid-start-file-system-router) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help

Expected behavior 🤔

It should generate source maps

Steps to reproduce 🕹

Steps:

  1. Create a new solid-start project
  2. Configure vite.config.js to have source maps enabled in build
  3. npm run build
  4. Error that no source maps were created
  5. You can verify this by checking for them in devtools

Context 🔦

No response

Your environment 🌎

  System:
    OS: Linux 6.2 Ubuntu 23.04 23.04 (Lunar Lobster)
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-1260P
    Memory: 7.95 GB / 15.22 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 20.5.1 - ~/.nvm/versions/node/v20.5.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v20.5.1/bin/yarn
    npm: 10.1.0 - ~/.nvm/versions/node/v20.5.1/bin/npm
    pnpm: 8.6.2 - ~/.nvm/versions/node/v20.5.1/bin/pnpm
  Browsers:
    Brave Browser: 118.1.59.120
  npmPackages:
    vite: ^4.4.9 => 4.5.0 
@elijah629 elijah629 added the bug Something isn't working label Oct 21, 2023
@ryansolid
Copy link
Member

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants