Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with Framework changes to RSocket routing and new message/x.rsocket.routing.v0 requests #17135

Closed
wilkinsona opened this issue Jun 13, 2019 · 3 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jun 13, 2019

Latest Framework snapshots are causing RSocketWebSocketNettyRouteProviderTests to fail with the following:

java.lang.IllegalArgumentException: No encoder for java.lang.String
	at org.springframework.messaging.rsocket.RSocketStrategies.encoder(RSocketStrategies.java:61)
	at org.springframework.messaging.rsocket.DefaultRSocketRequester$DefaultRequestSpec.encodeMetadata(DefaultRSocketRequester.java:274)
	at org.springframework.messaging.rsocket.DefaultRSocketRequester$DefaultRequestSpec.lambda$getMetadata$6(DefaultRSocketRequester.java:252)

The request that can't be encoded has a MIME type of message/x.rsocket.routing.v0 that was added to Framework in this commit.

@wilkinsona wilkinsona added the type: bug A general bug label Jun 13, 2019
@wilkinsona wilkinsona added this to the 2.2.0.M4 milestone Jun 13, 2019
@wilkinsona wilkinsona self-assigned this Jun 13, 2019
@wilkinsona wilkinsona changed the title Auto-configured RSocket strategies cannot encode message/x.rsocket.routing.v0 requests Align with Framework changes to RSocket routing and new message/x.rsocket.routing.v0 requests Jun 13, 2019
@wilkinsona wilkinsona added type: task A general task and removed type: bug A general bug labels Jun 13, 2019
@wilkinsona
Copy link
Member Author

wilkinsona commented Jun 13, 2019

@bclozel @rstoyanchev Can you please confirm that this was the right change to make? Given that all mime types or just text/plain are the two options for CharSequenceEncoder it seemed reasonable. It's also the encoder that Framework's tests use so hopefully I'm not too far wide of the mark.

@rstoyanchev
Copy link
Contributor

That's a reasonable change for now and in general, although you should be able to switch back to the stricter "text/plain" when spring-projects/spring-framework#23137 is resolved.

@philwebb
Copy link
Member

I've raised #17146 to make sure we remember to switch back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants