Cannot overwrite content-type response header with WebFlux [SPR-17415]

[spring-projects-issues]

Peter Luttrell opened SPR-17415 and commented

I originally reported spring-projects/spring-boot#13635 which Brian Clozel troubleshooted and transferred to #21619 and then resolved. This resolved my original issue when I upgraded to Spring Boot 2.1.0.M4 (Spring 5.1.0.RELEASE).

But when I upgraded to Spring Boot 2.1.0.RC1 (Spring 5.1.1.RELEASE), the issue came back. 

Here is sample output in the original Spring Boot report and the example in #21619 when using 2.1.0.M4/5.1.0.RELEASE:

$ http localhost:8080/binary-test apiKey==bad
HTTP/1.1 403 Forbidden
Content-Length: 36
Content-Type: application/json;charset=UTF-8

{
    "developerMessage": "access denied"
}


$ http localhost:8080/test                   
HTTP/1.1 400 Bad Request
Content-Length: 32
Content-Type: application/json

{
    "field1": "test-error-response"
}

 

And here is exactly the same two calls when I only switch to 2.1.0.RC1/5.1.1.RELEASE:

$ http localhost:8080/binary-test apiKey==bad
HTTP/1.1 406 Not Acceptable
Content-Length: 157
Content-Type: application/json;charset=UTF-8

{
    "error": "Not Acceptable",
    "message": "Could not find acceptable representation",
    "path": "/binary-test",
    "status": 406,
    "timestamp": "2018-10-19T23:33:58.349+0000"
}

$ http localhost:8080/test                   
HTTP/1.1 400 Bad Request
Content-Length: 32
Content-Type: text/plain;charset=UTF-8
Content-Type: application/json


http: error: LookupError: unknown encoding: UTF-8, application/json

 

 

---

Affects: 5.1.1

Issue Links:

• ResponseEntityResultHandler does not overwrite existing response headers [SPR-17082] #21619 ResponseEntityResultHandler does not overwrite existing response headers

[spring-projects-issues]

Peter Luttrell commented

Here's a quick project that shows the issue in at least one case. https://github.com/pluttrell/406-bug. I believe that there are more cases that trigger this issue.

I think it's interesting that the unit test with the WebTestClient now passes but the manual calls exhibit the bug. When I originally reported this issue both the same unit test and manual tests exhibited the same problem. And were both fixed with the original fix.

[spring-projects-issues]

Brian Clozel commented

This has been fixed and should be shortly available in Spring Framework and Spring Boot SNAPSHOTs. This has been introduced in #21783 for Reactor Netty and Tomcat. Using Jetty as a server in your sample works as expected.

Thanks for the report!