Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Jaxb2Marshaller createMarshaller() and createUnmarshaller() methods #22708

Closed
andrei-ivanov opened this issue Mar 29, 2019 · 3 comments
Closed
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Milestone

Comments

@andrei-ivanov
Copy link

Affects: 5.1.5


Having defined a Jaxb2Marshaller with some custom properties to be used with Spring AMQP, I'm trying now to re-use it and to use the JAXB Marshaller/Unmarshaller it can generate directly with a javax.ws.rs.ext.ContextResolver<Marshaller>, but those methods are protected so I can't invoke them directly.
As a temporary workaround, I've used reflection.

Please make them public.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 29, 2019
@Kunxian615
Copy link

啊啊

@jhoeller jhoeller self-assigned this Mar 31, 2019
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 31, 2019
@jhoeller jhoeller modified the milestones: 5.2 M2, 5.2 M1 Mar 31, 2019
@sbrannen sbrannen changed the title Expose Jaxb2Marshaller createMarshaller/createUnmarshaller Expose Jaxb2Marshaller createMarshaller() and createUnmarshaller() methods Mar 31, 2019
@andrei-ivanov
Copy link
Author

Thank you 🙂
Any chance of a backport to 5.1?

@jhoeller
Copy link
Contributor

jhoeller commented Apr 2, 2019

I'm afraid this isn't a backport candidate since such changes of visibility can break existing code extending Jaxb2Marshaller. For the time being, you could create such an extension yourself: overriding createMarshaller and createUnmarshaller with plain super delegation but public visibility at the subclass level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants