Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding is*Enabled() methods to LogAccessor #22862

Closed
garyrussell opened this issue Apr 30, 2019 · 0 comments
Closed

Consider adding is*Enabled() methods to LogAccessor #22862

garyrussell opened this issue Apr 30, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2 M2

Comments

@garyrussell
Copy link
Contributor

Affects: 5.2.x

Please consider adding is*Enabled() methods to LogAccessor.

I can see 2 use cases...

  • a superclass with a protected final LogAccessor with many subclasses - it would make the transition easier because we wouldn't have to transition every subclass at the same time.
  • logging non-final (or effectively final) variables from the Supplier lambda - right now, we have to create a dummy final variable before logging; with these methods, we could continue to use the existing "if enabled" style for these cases.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 30, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 30, 2019
@jhoeller jhoeller self-assigned this Apr 30, 2019
@jhoeller jhoeller added this to the 5.2 M2 milestone Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M2
Development

No branches or pull requests
3 participants
@garyrussell @jhoeller @spring-projects-issues