Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultMultipartMessageReader.FilePart.transferTo fails occasionally #23130

Closed
poutsma opened this issue Jun 13, 2019 · 2 comments
Closed

DefaultMultipartMessageReader.FilePart.transferTo fails occasionally #23130

poutsma opened this issue Jun 13, 2019 · 2 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
5.2 RC1

Comments

@poutsma
Copy link
Contributor

poutsma commented Jun 13, 2019 •
edited
Loading

When using the DefaultMultipartMessageReader to parse multipart file uploads, the FilePart.transferTo fails.
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Jun 13, 2019
@poutsma poutsma added this to the 5.2 RC1 milestone Jun 13, 2019
@poutsma poutsma self-assigned this Jun 13, 2019
@poutsma
Copy link
Contributor Author

poutsma commented Jun 13, 2019

This seems related: http://niklasschlimm.blogspot.com/2012/05/java-7-9-nio2-file-channels-on-test.html

@poutsma poutsma changed the title DefaultMultipartMessageReader.FilePart.transferTo fails under Tomcat DefaultMultipartMessageReader.FilePart.transferTo fails occasionally Jun 13, 2019
@poutsma
Copy link
Contributor Author

poutsma commented Jun 14, 2019

It seems that the channel is closed before all bytes are written, so we should delay closing it (similar to beae1fb#diff-e05fff38ca52a68fabede90954151091R152)

@poutsma poutsma mentioned this issue Jun 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
5.2 RC1
Development

No branches or pull requests
1 participant
@poutsma