Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExchangeFilterFunctions.basicAuthentication(String, String) should cache the encoded credentials #23256

Closed
membersound opened this issue Jul 9, 2019 · 2 comments
Closed

ExchangeFilterFunctions.basicAuthentication(String, String) should cache the encoded credentials #23256

membersound opened this issue Jul 9, 2019 · 2 comments
Assignees
@sbrannen
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.2 RC1

Comments

@membersound
Copy link

membersound commented Jul 9, 2019 •
edited by sbrannen
Loading

Similar to gh-23204, ExchangeFilterFunctions.basicAuthentication(String, String) should also cache the encoded credentials.

At present, a new encoding takes place for any web request made through a WebClient configured with .filter(ExchangeFilterFunctions.basicAuthentication(user, pass)).
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 9, 2019
@sbrannen sbrannen changed the title ExchangeFilterFunctions.basicAuthentication() should cache the encoded credentials ExchangeFilterFunctions.basicAuthentication(String, String) should cache the encoded credentials Jul 9, 2019
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jul 9, 2019
@sbrannen sbrannen self-assigned this Jul 9, 2019
@sbrannen
Copy link
Member

sbrannen commented Jul 9, 2019

Good catch. I'll make the necessary changes in ExchangeFilterFunctions as well.

@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 9, 2019
@sbrannen sbrannen added this to the 5.2 RC1 milestone Jul 9, 2019
@sbrannen
Copy link
Member

sbrannen commented Jul 9, 2019

This has been resolved in f0d5994.

@sbrannen sbrannen added the type: enhancement A general enhancement label Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 RC1
Development

No branches or pull requests
3 participants
@sbrannen @membersound @spring-projects-issues