-
Notifications
You must be signed in to change notification settings - Fork 38k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequestSpec.metadata(Consumer<RequestSpec>) not intuitive name #23639
Comments
The method returns Data is not additive, unlike (composite) metadata, and that means it can only be set by one party. To allow setting both it would have to be something that takes over the request definition: ResponseSpec apply(Function<ResponseSpec, RequestSpec) configurer); |
I see that invoking |
This has been addressed as part of #23649 and is now: RequestSpec metadata(Consumer<MetadataSpec<?>> configurer); |
The name for
RSocketRequester
RequestSpec.metadata(Consumer) is not very intuitive since it can modify the entireRequestSpec
. I wonder if we should modify the name or change the argument?The text was updated successfully, but these errors were encountered: