Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to override the SameSite attribute of JSESSIONID cookie #23785

Closed
AaronZhengkk opened this issue Oct 12, 2019 · 5 comments
Closed

How to override the SameSite attribute of JSESSIONID cookie #23785

AaronZhengkk opened this issue Oct 12, 2019 · 5 comments

Comments

@AaronZhengkk
Copy link

@boommanpro You should be able to add a cookie initializer which can override the default value. If you have additional questions problems, you might want to create a ticket in JIRA https://jira.spring.io/browse/SPR

Originally posted by @rwinch in #1889 (comment)
@AaronZhengkk
Copy link
Author

@rwinch Does cookie initializer no longer exist in version 5.1.8?How do I override the default values in version 5.1.8?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 12, 2019
@AaronZhengkk AaronZhengkk changed the title @BoomManPro You should be able to [add a cookie initializer](https://github.com/vpavic/spring-framework/blob/8d3162352211c7edf05518c03236dae64223388e/spring-web/src/main/java/org/springframework/web/server/session/CookieWebSessionIdResolver.java#L91) which can override the default value. If you have additional questions problems, you might want to create a ticket in JIRA https://jira.spring.io/browse/SPR How to override the SameSite attribute of JSESSIONID Cookie Oct 12, 2019
@AaronZhengkk AaronZhengkk changed the title How to override the SameSite attribute of JSESSIONID Cookie How to override the SameSite attribute of JSESSIONID cookie Oct 12, 2019
@rstoyanchev
Copy link
Contributor

@AaronZhengkk the link provided Rob is still valid. The method has not gone away and is still there. I don't understand your question, what doesn't exist in 5.1.8?

@rstoyanchev rstoyanchev added the status: waiting-for-feedback We need additional information before we can continue label Nov 28, 2019
@rstoyanchev
Copy link
Contributor

Note also that there was an issue with actually having sameSite propagate through to the client, see #23693. It's possible that you were running into that.

@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Dec 5, 2019
@spring-projects-issues
Copy link
Collaborator

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@spring-projects-issues spring-projects-issues removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rstoyanchev @AaronZhengkk @spring-projects-issues