Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL: Proper type for YEAR and TINYINT #3201

Closed
Necoro opened this issue Feb 14, 2024 · 1 comment · Fixed by #3298
Closed

MySQL: Proper type for YEAR and TINYINT #3201

Necoro opened this issue Feb 14, 2024 · 1 comment · Fixed by #3298
Labels
📚 mysql bug Something isn't working
Milestone

Comments

@Necoro
Copy link

Necoro commented Feb 14, 2024

Version

1.25.0

What happened?

In issue #3088, SMALLINT was (correctly) changed from int32 to int16.
Surprisingly, TINYINT, which should have int8, has not been touched, resulting in the situation that TINYINT is now larger than SMALLINT.

Additionally, YEAR is checked for signed vs unsigned, even though this flag is not possible for MySQL: it should always result in an uint16.

FWIW: Closing this issue will also close #1856

Relevant log output

No response

Database schema

No response

SQL queries

No response

Configuration

No response

Playground URL

No response

What operating system are you using?

Linux

What database engines are you using?

MySQL

What type of code are you generating?

Go

@Necoro Necoro added bug Something isn't working triage New issues that hasn't been reviewed labels Feb 14, 2024
@kyleconroy kyleconroy added this to the 1.26.0 milestone Feb 15, 2024
@kyleconroy kyleconroy removed the triage New issues that hasn't been reviewed label Feb 15, 2024
@kyleconroy
Copy link
Collaborator

@Necoro this is a good catch. We'll make sure to make this change before we release 1.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 mysql bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants