Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError with np.bool when fitting NGBRegressor with Exponential distribution #336

Closed
DumasCharles opened this issue Oct 17, 2023 · 3 comments

Comments

@DumasCharles
Copy link

Package Name: ngboost
Package Version: 0.4.1
Operating System: Windows
Python Version: 3.10

When I try to fit a NGBRegressor with Dist=Exponential. I get the AttributeError below:

raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'bool'.
`np.bool` was a deprecated alias for the builtin `bool`. To avoid this error in existing code, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations. Did you mean: 'bool_'?

This is the same issue as mentioned in #331 , and I understand it will be resolved with #320. But the numpy deprecation leads to an Error and not a Warning, so it is quite critical.

Thank you :)

@ryan-wolbeck
Copy link
Collaborator

I agree, thanks for the note. I've provided an update on the findings I'm working through here: #320 (comment)

@ryan-wolbeck
Copy link
Collaborator

This should be fixed but let us know if you still have issues

pip install ngboost==0.4.2

@DumasCharles
Copy link
Author

Yes it works now, thank you very much for acting quickly on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants