Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shortcuts in storybook optionable or move to addon #3196

Closed
Kiwka opened this issue Mar 13, 2018 · 4 comments
Closed

Make shortcuts in storybook optionable or move to addon #3196

Kiwka opened this issue Mar 13, 2018 · 4 comments

Comments

@Kiwka
Copy link
Contributor

Kiwka commented Mar 13, 2018

Issue details

On one of the components that we have in our storybook, we have several shortcuts that we want add functionality to. One of them overlaps with storybook default one ⌘ ⇧ C, and disable us to handle this shortcut properly on the component.

My proposal is to add the possibility to enable or disable shortcuts in storybook through addon-options, keeping them as enabled by default.

@PunitGr
Copy link
Contributor

PunitGr commented Mar 17, 2018

Hello @Kiwka @igor-dv 👋

I'd love to take this up!

Does this spec seem fine to you folks?

setOptions({
    ...
    enableShortcuts: false, // true by default
})

@Hypnosphi
Copy link
Member

Sure @PunitGr go for it

@Kiwka
Copy link
Contributor Author

Kiwka commented Mar 19, 2018

Thanks @PunitGr for looking into this 🙇‍♀️

@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.0

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants