Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'withMarkdownNotes' isn't included in latest npm package (3.3.15) #3220

Closed
cameron-lindsay opened this issue Mar 15, 2018 · 4 comments
Closed

Comments

@cameron-lindsay
Copy link

cameron-lindsay commented Mar 15, 2018

Reproduce

  • Create a new react storybook project
  • Install the latest '@storybook/addon-notes' npm package (3.3.15 at this time)
  • Import 'withMarkdownNotes' into a story module and hook it up as per the documentation
  • Run storybook
  • In browser, navigate to your story.
  • Error appears: "Object(...) is not a function" etc....

I have examined the package and the code for 'withMarkdownNotes' simply isn't there. 'withNotes' still works fine.

@danielduan
Copy link
Member

@Hypnosphi @shilman any changes here? sounds kind of serious

@Hypnosphi
Copy link
Member

It should be present in @storybook/addon-notes@3.4.0-rc.2

@dangreenisrael
Copy link
Member

dangreenisrael commented Mar 17, 2018

@cameron-lindsay Can you post the devDependencies portion of your package.json file?

@danielduan
Copy link
Member

is this intended to be released with 3.4? if so, let's close this.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants