Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Update app.json regardless of Expo #143

Closed
deavial opened this issue Sep 16, 2019 · 3 comments
Closed

Feature Request: Update app.json regardless of Expo #143

deavial opened this issue Sep 16, 2019 · 3 comments

Comments

@deavial
Copy link

deavial commented Sep 16, 2019

The latest React Native for Android can not import package.json (see #25645).

The current release will update app.json if the project is expo, but won't update it for normal apps. It would be great if the detection would update app.json if version exists in it regardless of the expo flag. This would allow us to work around the react-native issue without requiring a third-party lib.

@stovmascript
Copy link
Owner

I'm not catching on with reference to that RN issue. Can you clarify how you're using RNV?

@deavial
Copy link
Author

deavial commented Sep 16, 2019

that will work too, wasn't aware of that. but if the app.json were being updated instead of being ignored, wouldn't have to use another library at all.

@stovmascript
Copy link
Owner

stovmascript commented Sep 16, 2019

I understand, but I think it would make RNV unpredictable if it was updating values in places it shouldn't.

app.json is only updated for Expo apps because that's the only place Expo apps read version info. If the app is ejected (or non-Expo), RNV will default back to updating native code because in that case, that's the only place the version info can be read inside the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants