BUG: Invoice email being sent every time check order is saved in "success" status

[dparker1005]

To replicate, create a "Check" order in "Success" status and save it repeatedly. The user associated with the order will receive an Invoice email every time that the order is saved.

This should be addressed in the pmpropbc_send_invoice_email() function here:

pmpro-pay-by-check/pmpro-pay-by-check.php

Lines 590 to 607 in 6ae07a8

	/**
	* Send Invoice to user if/when changing order status to "success" for Check based payment.
	*
	* @param MemberOrder $morder - Updated order as it's being saved
	*/
	function pmpropbc_send_invoice_email( $morder ) {
	// Only worry about this if the order status was changed to "success"
	if ( 'check' === strtolower( $morder->payment_type ) && 'success' === $morder->status ) {
	$recipient = get_user_by( 'ID', $morder->user_id );
	$invoice_email = new PMProEmail();
	$invoice_email->sendInvoiceEmail( $recipient, $morder );
	}
	}
	add_action( 'pmpro_updated_order', 'pmpropbc_send_invoice_email', 10, 1 );

Suggested fix is to save in order meta when an invoice email has already been sent for a given order, and if that is the case, to not allow another invoice email to be sent.

[cremigerhonig]

for me no mail is send at all

if I change from pending to sucess there is no mail sent to user, why?