Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOPHUS_FMT_ARG causes compilization error when SOPHUS_USE_BASIC_LOGGING=ON #436

Closed
dzywater opened this issue Dec 26, 2022 · 3 comments
Closed

SOPHUS_FMT_ARG causes compilization error when SOPHUS_USE_BASIC_LOGGING=ON #436

dzywater opened this issue Dec 26, 2022 · 3 comments
Labels
bug

Comments

@dzywater
Copy link

I think:

Sophus/sophus/common.hpp

Line 21 in 1cba0d8

#define SOPHUS_FMT_ARG(arg)

#define SOPHUS_FMT_ARG(arg)
should be
#define SOPHUS_FMT_ARG(arg) arg
instead
@dzywater dzywater added the bug label Dec 26, 2022
@dzywater dzywater changed the title SOPHUS_USE_BASIC_LOGGING causes compilization error when SOPHUS_USE_BASIC_LOGGING=ON SOPHUS_FMT_ARG causes compilization error when SOPHUS_USE_BASIC_LOGGING=ON Dec 26, 2022
This was referenced Mar 26, 2023
Closed
Closed
@nachovizzo
Copy link

Opened #502 with the fix, hopefully they will merge it soonish

@zjsyj
Copy link

zjsyj commented Jun 14, 2023

this bug is still there
Sophus version: 1.22.10
OS: windows 10.0.22621.1778
Compiler: cl.exe 19.29

@strasdat strasdat mentioned this issue Jun 10, 2024
Merged
@strasdat
Copy link
Owner

This should be fixed by #538, since it removes BASIC_LOGGING and the fmt dependency and includes corresponding CI coverage.

@nachovizzo nachovizzo mentioned this issue Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@strasdat @zjsyj @nachovizzo @dzywater