Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all testcase related files to TestCases? #55

Open
bigfooted opened this issue Jan 10, 2021 · 3 comments
Open

Move all testcase related files to TestCases? #55

bigfooted opened this issue Jan 10, 2021 · 3 comments
Assignees
Labels

Comments

@bigfooted
Copy link
Contributor

I propose to move all testcase related files to this repository. That means moving the config files from the SU2 repository to this repository. I think that will make it easier to:

  1. see if all files for the testcase are present (cfg + su2 file at the very least)
  2. test if the case works because all files to run are present.

I'd like to hear your opinion.

@bigfooted bigfooted self-assigned this Jan 10, 2021
@pcarruscag
Copy link
Member

pcarruscag commented Jan 24, 2021

A lot of people don't get notified for this Repo.

I find it convenient to have reference files for files diffs in the code repo, less hassle when updates are required and file diffs break more easily than the other tests because there is 0 tolerance.

cfg + su2 + restart sounds like a good idea to move to testcases

@pcarruscag
Copy link
Member

I remembered something, the version number in the testcase configs is updated automatically by a github action, we would need to setup something like that for this repo as well.

@bigfooted
Copy link
Contributor Author

do you know how that works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants