Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The security scanning jobs should only fail jobs if the PR adds a security issue #2751

Open
skitt opened this issue Oct 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working priority:low

Comments

@skitt
Copy link
Member

skitt commented Oct 13, 2023

What happened:

Currently, security scanning jobs fail a PR if any of the project’s dependencies are identified as containing a known vulnerability. This prevents us merging PRs when a vulnerability is found, until the project updates to address that.

What you expected to happen:

PRs should only be blocked if they introduce a security vulnerability, i.e. add a dependency with a known vulnerability.

@skitt skitt added the bug Something isn't working label Oct 13, 2023
@dfarrell07 dfarrell07 self-assigned this Oct 24, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 22, 2024
@skitt skitt removed the stale label Feb 22, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:low
Projects
Status: Backlog
Development

No branches or pull requests

2 participants