Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.npmignore file #69

Open
skibz opened this issue Nov 4, 2021 · 0 comments
Open

.npmignore file #69

skibz opened this issue Nov 4, 2021 · 0 comments

Comments

@skibz
Copy link

skibz commented Nov 4, 2021

Is there a valid reason why this package includes gifs and pngs when installed from NPM? They weigh in at 16 megabytes, and I doubt downstream codebases are likely to use them.

ant$ du -h node_modules/awesome-qr
4.0K	node_modules/awesome-qr/test
 48K	node_modules/awesome-qr/dist
 16M	node_modules/awesome-qr/art
 76K	node_modules/awesome-qr/lib/gif.js
 24K	node_modules/awesome-qr/lib/gifuct-js
192K	node_modules/awesome-qr/lib
 48K	node_modules/awesome-qr/src/gif.js
 12K	node_modules/awesome-qr/src/gifuct-js
128K	node_modules/awesome-qr/src
 16M	node_modules/awesome-qr

Please could we add a .npmignore file that prevents these images (and any other source code that isn't required to use the library) from being published?

I'd be happy to submit a patch for this, if you're open to the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant