Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading @​sveltejs/kit from 1.0.0-next.117 to 1.0.0-next.119 results in runtime error #1809

Closed
patrickleet opened this issue Jul 2, 2021 · 2 comments

Comments

@patrickleet
Copy link
Contributor

Describe the bug
Upgrading @​sveltejs/kit from 1.0.0-next.117 to 1.0.0-next.119 results in runtime error

Logs
Please include browser console and server logs around the time this bug occurred.

➜  ~ k logs -n jx-presidio-pr-18 presidio-00001-deployment-7598655467-wshls user-container
file:///usr/src/app/build/index.js:1552
  serverFetch: hooks.serverFetch || fetch
                                    ^

ReferenceError: fetch is not defined
    at get_hooks (file:///usr/src/app/build/index.js:1552:37)
    at init (file:///usr/src/app/build/index.js:1512:12)
    at file:///usr/src/app/build/index.js:1574:1
    at ModuleJob.run (node:internal/modules/esm/module_job:175:25)
    at async Loader.import (node:internal/modules/esm/loader:178:24)
    at async Object.loadESM (node:internal/process/esm_loader:68:5)

To Reproduce
Please make sure you've tested with the latest versions of Svelte and SvelteKit.

Use the node adapter - build, then start project with node ./build/index.js

Expected behavior
Node adapter still works

Stacktraces
If you have a stack trace to include, we recommend putting inside a <details> block for the sake of the thread's readability:

Stack trace

file:///usr/src/app/build/index.js:1552
serverFetch: hooks.serverFetch || fetch
^

ReferenceError: fetch is not defined
at get_hooks (file:///usr/src/app/build/index.js:1552:37)
at init (file:///usr/src/app/build/index.js:1512:12)
at file:///usr/src/app/build/index.js:1574:1
at ModuleJob.run (node:internal/modules/esm/module_job:175:25)
at async Loader.import (node:internal/modules/esm/loader:178:24)
at async Object.loadESM (node:internal/process/esm_loader:68:5)

Information about your SvelteKit Installation:

Diagnostics

npx envinfo --system --npmPackages svelte,@sveltejs/kit,@sveltejs/adapter-node,@sveltejs/adapter-static,@sveltejs/adapter-begin,@sveltejs/adapter-netlify,@sveltejs/adapter-vercel vite --binaries --browsers

System:
OS: macOS 11.4
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Memory: 7.78 GB / 64.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.3.0 - /usr/local/bin/node
Yarn: 1.22.4 - ~/.yarn/bin/yarn
npm: 7.15.1 - /usr/local/bin/npm
Watchman: 2021.06.07.00 - /usr/local/bin/watchman
Browsers:
Chrome: 91.0.4472.114
Firefox: 82.0.2
Safari: 14.1.1
npmPackages:
@sveltejs/adapter-node: 1.0.0-next.27 => 1.0.0-next.27
@sveltejs/kit: 1.0.0-next.119 => 1.0.0-next.117
svelte: 3.38.3 => 3.38.3

Severity
How severe an issue is this bug to you? Is this annoying, blocking some users, blocking an upgrade or blocking your usage of SvelteKit entirely?

Blocking upgrade - just wanted to point it out as my CI tells me every minor version change if things are still working

Note: the more honest and specific you are here the more we will take you seriously.

Additional context
Add any other context about the problem here.

@GrygrFlzr
Copy link
Member

Duplicate of #1784

@patrickleet
Copy link
Contributor Author

ah, duplicate - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants