Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paltas pip version not consistent with latest lenstronomy versions #48

Open
sibirrer opened this issue Oct 27, 2023 · 3 comments
Open

Comments

@sibirrer
Copy link
Collaborator

the pip version of paltas causes an error when running with later versions of lenstronomy (the main branch is ok).
Can you release a new paltas version?
The line we are talking about is here:

ProfileListBase._import_class(model,None,None,None).param_names

(also, here you access a private lenstronomy function, which should be avoided)

@swagnercarena
Copy link
Owner

Hi Simon,

Thank you for the feedback!

I will release a new pip version and mark this issue as complete when it is done.

Is there a better way to get parameter names for an arbitrary profile in lenstronomy? I can make a feature request on lenstronomy if that would be useful.

@sibirrer
Copy link
Collaborator Author

Thank you Sebastian.
I don't think there is currently a much better way. Perhaps we can have the function as a public function outside of the class and have more of the input arguments optional. That can make it easier for you.

@sibirrer
Copy link
Collaborator Author

I just merged a pull request to the lenstronomy main branch for a decoupled function of what you (hopefully) want: lenstronomy/lenstronomy#543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants